Remove go-bindata #2528
Remove go-bindata #2528
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -25,18 +25,12 @@ const ( | |||
| // This directory contains all the SSL certificates that are specified in Ingress rules. | |||
| // The name of each file is <namespace>-<secret name>.pem. The content is the concatenated | |||
| // certificate and key. | |||
| DefaultSSLDirectory = "/ingress-controller/ssl" | |||
| DefaultSSLDirectory = "/etc/ingress-controller/ssl" | |||
There was a problem hiding this comment.
I know this is not directly related to this PR but I've been thinking, since you're making a change to the layout here, could you also set the container work directory to /etc/nginx? :)
That'd be super convenient to be able to show the config with just kubectl exec ... -- cat nginx.conf instead of the full path.
Just a suggestion.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2528 +/- ##
==========================================
- Coverage 41.57% 40.73% -0.84%
==========================================
Files 74 73 -1
Lines 5270 5015 -255
==========================================
- Hits 2191 2043 -148
+ Misses 2782 2700 -82
+ Partials 297 272 -25
Continue to review full report at Codecov.
|
No description provided.