Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix manifest URL for GKE + Azure #2544

Merged

Conversation

schallert
Copy link
Contributor

What this PR does / why we need it: This PR fixes broken links for the cloud-generic.yaml manifests in the GKE and Azure sections of the deployment guide.

Which issue this PR fixes: None.

Special notes for your reviewer: None.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2018
@aledbf
Copy link
Member

aledbf commented May 20, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, schallert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2018
@aledbf
Copy link
Member

aledbf commented May 20, 2018

@schallert thanks!

@codecov-io
Copy link

Codecov Report

Merging #2544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2544   +/-   ##
======================================
  Coverage    40.7%   40.7%           
======================================
  Files          73      73           
  Lines        5034    5034           
======================================
  Hits         2049    2049           
  Misses       2711    2711           
  Partials      274     274

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa256ac...0add51f. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit d61eb2d into kubernetes:master May 20, 2018
@schallert schallert deleted the schallert/fix_cloud_generic_link branch May 20, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants