Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use better defaults for proxy-next-upstream(-tries) #2554

Merged
merged 1 commit into from
May 24, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
By default ingress-nginx configures Nginx to retry next upstream indefinitely for any of error timeout invalid_header http_502 http_503 http_504. This is a bit extreme and it potentially hides important errors. The PR changes the defaults to be more restrictive. Note that these values can still be customized per ingress.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2018
@ElvinEfendi
Copy link
Member Author

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented May 22, 2018

@ElvinEfendi not sure about removing http_502 http_503.

@ElvinEfendi
Copy link
Member Author

ElvinEfendi commented May 24, 2018

@aledbf I'd have expected this to default to what Nginx has as default value: http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_next_upstream which is error timeout.

For example it is a common practice to return 503 during maintenance (for SEO purposes returning 503 is crucial) which does not make sense to retry.

Users can customize the value later if they need to, both through configmap as well as through Ingress annotation.

@aledbf
Copy link
Member

aledbf commented May 24, 2018

@ElvinEfendi I don't share your opinion but to be consistent I think we need to provide the same default values

@aledbf
Copy link
Member

aledbf commented May 24, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0d80e0d into kubernetes:master May 24, 2018
@ElvinEfendi ElvinEfendi deleted the better-defaults branch May 25, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants