-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add traffic shifting strategy #2560
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@chenqz1987 not sure about this because requires too many changes |
@aledbf yeah... but it is a very valuable feature, and we can discuss the design and plan together. Do you have any idea or comments about the design? |
+1 |
1 similar comment
+1 |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
+1 |
1 similar comment
+1 |
Codecov Report
@@ Coverage Diff @@
## master #2560 +/- ##
==========================================
- Coverage 40.77% 38.95% -1.82%
==========================================
Files 74 76 +2
Lines 5077 5650 +573
==========================================
+ Hits 2070 2201 +131
- Misses 2724 3133 +409
- Partials 283 316 +33
Continue to review full report at Codecov.
|
+1 |
+1 |
1 similar comment
+1 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chenquanzhao If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chenquanzhao thanks for this PR! I'd like to help to get this feature out as soon as possible. As @aledbf mentions above the PR introduces significant changes. I drafted a quick proposal that achieves approximately the same result with minimal changes only: https://docs.google.com/document/d/1qKTyLBLuKIYE6d6BsFXRM7zYB-2MUk6qJjtBL1KCz78/edit?usp=sharing It would be great to get your opinions on it. |
@ElvinEfendi Appreciate your help and I already add some comments to the document for your reference. |
Hi, any updates regarding this PR? |
@yaron2 the feature is being implemented at Shopify#120. Most likely it will land in dev build of master branch by the end of this week. |
What this PR does / why we need it:
For the sake of reducing downtime and risk of updating a service, we usually adopt Blue-Green Deployment or Gray Deployment that ensures the coexistence of the old and new service version. We can shift partial traffic to the new service by weight percentage or some extra routing rules, such as some keyword from cookie or request header and so on. And nginx ingress controller is served as the traffic entrypoint for all cluster services, it should offer the capability of traffic management.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #2419Special notes for your reviewer:
Design doc: https://docs.google.com/document/d/1AkffGGtjy38n6GXRlTMPQpRUsto8zKjzCroZcJuXIs8/edit?usp=sharing
@aledbf