Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access log improvements #2591

Merged
merged 2 commits into from
May 31, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
When using a catch-all ingress log annotation is ignored - as a result access logging gets turned off.
The PR fixes that and also disables access logging for /configuration endpoint.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2018
@ElvinEfendi
Copy link
Member Author

/assign @aledbf

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2018
@aledbf
Copy link
Member

aledbf commented May 31, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2018
@ElvinEfendi
Copy link
Member Author

disabling access log in /configuration causing some Lua e2e tests to fail - I'm looking into it.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2018
@codecov-io
Copy link

Codecov Report

Merging #2591 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2591      +/-   ##
==========================================
- Coverage   40.54%   40.54%   -0.01%     
==========================================
  Files          75       75              
  Lines        5105     5106       +1     
==========================================
  Hits         2070     2070              
- Misses       2754     2755       +1     
  Partials      281      281
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 2.22% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeab200...d4e6c0d. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented May 31, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 88cb4fa into kubernetes:master May 31, 2018
@ElvinEfendi ElvinEfendi deleted the access-log-improvements branch May 31, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants