-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access log improvements #2591
Access log improvements #2591
Conversation
/assign @aledbf |
/approve |
disabling access log in |
21bd950
to
d4e6c0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2591 +/- ##
==========================================
- Coverage 40.54% 40.54% -0.01%
==========================================
Files 75 75
Lines 5105 5106 +1
==========================================
Hits 2070 2070
- Misses 2754 2755 +1
Partials 281 281
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
When using a catch-all ingress log annotation is ignored - as a result access logging gets turned off.
The PR fixes that and also disables access logging for
/configuration
endpoint.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: