Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix: are be->are/to on->to #2592

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Typo fix: are be->are/to on->to #2592

merged 1 commit into from
Jun 1, 2018

Conversation

AdamDang
Copy link
Contributor

@AdamDang AdamDang commented Jun 1, 2018

Line 11: are be->are
Line 13: to on->to

@AdamDang
Typo fix: are be->are/to on->to
712e243 
are be->are
to on->to
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2018
@AdamDang
Copy link
Contributor Author

AdamDang commented Jun 1, 2018

/assign @justinsb

@codecov-io
Copy link

Codecov Report

Merging #2592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2592   +/-   ##
=======================================
  Coverage   40.54%   40.54%           
=======================================
  Files          75       75           
  Lines        5106     5106           
=======================================
  Hits         2070     2070           
  Misses       2755     2755           
  Partials      281      281

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88cb4fa...712e243. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 1, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018
@aledbf
Copy link
Member

aledbf commented Jun 1, 2018

@AdamDang thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamDang, aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit c9fcefe into kubernetes:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamDang @codecov-io @aledbf @k8s-ci-robot @justinsb