Always sort upstream list to provide stable iteration order #2598
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## master #2598 +/- ##
==========================================
+ Coverage 40.54% 40.58% +0.04%
==========================================
Files 75 75
Lines 5106 5098 -8
==========================================
- Hits 2070 2069 -1
+ Misses 2755 2750 -5
+ Partials 281 279 -2
Continue to review full report at Codecov.
|
aledbf
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -572,12 +572,6 @@ func (n *NGINXController) getBackendServers(ingresses []*extensions.Ingress) ([] | |||
| aUpstreams = append(aUpstreams, upstream) | |||
| } | |||
|
|
|||
| if n.cfg.SortBackends { | |||
There was a problem hiding this comment.
Maybe make the corresponding flag dummy and print a deprecation message?
There was a problem hiding this comment.
Scratch the deprecation part, I forgot that the flag also influenced the order of endpoints.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Using a sorted list avoids unnecessary reloads
Which issue this PR fixes: fixes #2596