Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginx to 1.15.0 and remove VTS module #2618

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Update nginx to 1.15.0 and remove VTS module #2618

merged 1 commit into from
Jun 14, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 11, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2018
@codecov-io
Copy link

Codecov Report

Merging #2618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2618   +/-   ##
=======================================
  Coverage   40.68%   40.68%           
=======================================
  Files          75       75           
  Lines        5108     5108           
=======================================
  Hits         2078     2078           
  Misses       2751     2751           
  Partials      279      279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc96d5c...8d73e23. Read the comment docs.

@chenquanzhao
Copy link

@aledbf By the way, what's the plan for nginx monitor after removing the vts module?

@aledbf
Copy link
Member Author

aledbf commented Jun 14, 2018

@chenqz1987 please check #2608

@chenquanzhao
Copy link

@aledbf ok, good.

@aledbf aledbf changed the title WIP Update nginx to 1.15.0 and remove VTS module Update nginx to 1.15.0 and remove VTS module Jun 14, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2018
@aledbf aledbf merged commit 9c6201b into kubernetes:master Jun 14, 2018
@aledbf aledbf deleted the update-nginx branch June 14, 2018 14:23
@itskingori itskingori mentioned this pull request Jun 14, 2018
Merged
fmejia97 pushed a commit to Shopify/ingress that referenced this pull request Jun 18, 2018
@aledbf @fmejia97
Update nginx to 1.15.0 and remove VTS module (kubernetes#2618)
cce16a7 
Update nginx to 1.15.0 and remove VTS module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @k8s-ci-robot @codecov-io @chenquanzhao