Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation doc on proxy buffer size #2625

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Add annotation doc on proxy buffer size #2625

merged 1 commit into from
Jun 12, 2018

Conversation

qiujian16
Copy link
Contributor

What this PR does / why we need it:
This is to add a doc about proxy buffer size annotation

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fix #2527

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #2625 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2625      +/-   ##
==========================================
+ Coverage   40.88%   40.94%   +0.05%     
==========================================
  Files          75       75              
  Lines        5129     5129              
==========================================
+ Hits         2097     2100       +3     
+ Misses       2753     2751       -2     
+ Partials      279      278       -1
Impacted Files Coverage Δ
cmd/nginx/main.go 25.37% <0%> (+2.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589de12...9218259. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 12, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2018
@aledbf
Copy link
Member

aledbf commented Jun 12, 2018

@qiujian16 thanks!

@k8s-ci-robot k8s-ci-robot merged commit f7359a6 into kubernetes:master Jun 12, 2018
@qiujian16 qiujian16 deleted the proxy-buffer-size-doc branch June 13, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy-buffer-size annotation is not shown in the annotation documentation
4 participants