Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wait informer initialization to read configuration #2658

Merged
merged 1 commit into from
Jun 17, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 17, 2018

What this PR does / why we need it:

Read configuration configmap while the controller is being initialized. This avoids passing health checks without having applied the configuration defined in the configmap.

Which issue this PR fixes:

fixes #2629

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 17, 2018
@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #2658 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2658      +/-   ##
==========================================
+ Coverage   40.75%   40.84%   +0.08%     
==========================================
  Files          72       72              
  Lines        5069     5073       +4     
==========================================
+ Hits         2066     2072       +6     
+ Misses       2721     2718       -3     
- Partials      282      283       +1
Impacted Files Coverage Δ
internal/ingress/controller/store/store.go 60.18% <100%> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373f8f5...4083911. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit da7bf10 into kubernetes:master Jun 17, 2018
@aledbf aledbf deleted the initial-configuration branch June 17, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wait for configuration configmap before passing health checks
4 participants