-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary sync when the leader change #2669
Conversation
/lgtm |
just curious what was the need before? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This particular code predates client-go and when the update of the status was part of the sync queue. Noe this runs in a different goroutine. |
Codecov Report
@@ Coverage Diff @@
## master #2669 +/- ##
==========================================
+ Coverage 40.84% 40.88% +0.04%
==========================================
Files 72 72
Lines 5073 5070 -3
==========================================
+ Hits 2072 2073 +1
+ Misses 2718 2715 -3
+ Partials 283 282 -1
Continue to review full report at Codecov.
|
What this PR does / why we need it:
There is no need (anymore) to force a sync when a new leader is elected