Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary sync when the leader change #2669

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 20, 2018

What this PR does / why we need it:

There is no need (anymore) to force a sync when a new leader is elected

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 20, 2018
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2018
@ElvinEfendi
Copy link
Member

ElvinEfendi commented Jun 20, 2018

just curious what was the need before?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member Author

aledbf commented Jun 20, 2018

just curious what was the need before?

This particular code predates client-go and when the update of the status was part of the sync queue. Noe this runs in a different goroutine.

@codecov-io
Copy link

Codecov Report

Merging #2669 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2669      +/-   ##
==========================================
+ Coverage   40.84%   40.88%   +0.04%     
==========================================
  Files          72       72              
  Lines        5073     5070       -3     
==========================================
+ Hits         2072     2073       +1     
+ Misses       2718     2715       -3     
+ Partials      283      282       -1
Impacted Files Coverage Δ
internal/ingress/status/status.go 75% <ø> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7220277...b0d6098. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 30c6567 into kubernetes:master Jun 20, 2018
@aledbf aledbf deleted the remove-sync branch June 21, 2018 14:01
aledbf added a commit to aledbf/ingress-nginx that referenced this pull request Jun 23, 2018
aledbf added a commit that referenced this pull request Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants