Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gzip compression level to be controlled via ConfigMap #2754

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

jstangroome
Copy link
Contributor

What this PR does / why we need it:
This PR allows the gzip compression level to be managed via the ConfigMap, just the same as the Brotli compression level is managed.

The historical default gzip compression level (5) is retained if the new gzip-level member of the ConfigMap is unspecified.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2018
@jstangroome jstangroome changed the title Allow gzip compress level to be controlled via ConfigMap Allow gzip compression level to be controlled via ConfigMap Jul 9, 2018
@aledbf aledbf self-assigned this Jul 9, 2018
@aledbf
Copy link
Member

aledbf commented Jul 9, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, jstangroome

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2018
@aledbf
Copy link
Member

aledbf commented Jul 9, 2018

@jstangroome thanks!

@k8s-ci-robot k8s-ci-robot merged commit 326ceec into kubernetes:master Jul 9, 2018
@jstangroome jstangroome deleted the jason-gzip-level branch November 20, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants