Fix regression introduced in #2732

[aledbf]

No description provided.

[codecov-io]

Codecov Report

Merging #2767 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2767      +/-   ##
==========================================
- Coverage    40.9%   40.87%   -0.03%     
==========================================
  Files          73       73              
  Lines        5105     5108       +3     
==========================================
  Hits         2088     2088              
- Misses       2728     2731       +3     
  Partials      289      289

Impacted Files	Coverage Δ
internal/ingress/controller/store/store.go	59.63% <0%> (-0.55%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5b3db...6013150. Read the comment docs.

[antoineco]

What happens exactly if nil is returned?

[aledbf]

What happens exactly if nil is returned?

I0710 13:42:32.162914       8 nginx.go:276] Starting NGINX process
I0710 13:42:32.163887       8 leaderelection.go:175] attempting to acquire leader lease  ingress-nginx/ingress-controller-leader-internal-nginx-int...
E0710 13:42:32.166196       8 controller.go:619] Error getting Ingress annotations "namespace/ing-int-foo-app-nginx-int": no object matching key "namespace/ing-int-foo-app-nginx-int" in local store
E0710 13:42:32.166469       8 runtime.go:66] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
/go/src/k8s.io/ingress-nginx/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:72
/go/src/k8s.io/ingress-nginx/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/go/src/k8s.io/ingress-nginx/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/go/src/runtime/asm_amd64.s:573
/usr/local/go/src/runtime/panic.go:502
/usr/local/go/src/runtime/panic.go:63
/usr/local/go/src/runtime/signal_unix.go:388
/go/src/k8s.io/ingress-nginx/internal/ingress/controller/controller.go:686

https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/controller.go#L628

[antoineco]

Makes sense, I was about to argue we should handle pointers if we pass pointers, but it's gonna be quite tedious to add if anns != nil to all these lines :D

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf,antoineco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

Makes sense, I was about to argue we should handle pointers if we pass pointers, but it's gonna be quite tedious to add if anns != nil to all these lines :D

I tried to do that but then I followed the pragmatic approach 😛