-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add help for tls prerequisite for ingress.yaml #2806
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/check-cla |
Which is true, GRPC uses http2 and ingress-nginx requires TLS to be enabled to use http2. |
Codecov Report
@@ Coverage Diff @@
## master #2806 +/- ##
==========================================
+ Coverage 47.33% 47.34% +0.01%
==========================================
Files 75 75
Lines 5413 5413
==========================================
+ Hits 2562 2563 +1
+ Misses 2527 2525 -2
- Partials 324 325 +1
Continue to review full report at Codecov.
|
/assign @antoineco |
@yogin16 please don't assign PRs manually |
sorry, about that. (first pr)
I now get that the checks needs to say ready before that. |
Indeed, besides what do you think about my comment above? |
/lgtm |
@yogin16 thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, yogin16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: conveys the prerequisite that to use grpc backend we need to have tls setup
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: