Escape $request_uri for external auth #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2811 +/- ##
==========================================
+ Coverage 47.33% 47.34% +0.01%
==========================================
Files 75 75
Lines 5413 5413
==========================================
+ Hits 2562 2563 +1
+ Misses 2527 2525 -2
- Partials 324 325 +1
Continue to review full report at Codecov.
|
|
Thanks @takonomura, would you mind adding an e2e test for this? |
k8s-ci-robot
added
size/L
takonomura
force-pushed
the
escape-request-uri
branch
2 times, most recently
from
636ca10
to
0f125d1
Compare
antoineco
suggested changes
Jul 19, 2018
test/e2e/framework/httpbin.go
Outdated
| return f.NewHttpbinDeploymentWithReplicas(1) | ||
| } | ||
|
|
||
| // NewHttpbinDeploymentWithReplicas creates a new deployment of the echoserver image in a particular namespace. Number of |
There was a problem hiding this comment.
Seems like a lot of repetitive code just for using a different image.
takonomura
force-pushed
the
escape-request-uri
branch
3 times, most recently
from
510315a
to
ed84fc7
Compare
takonomura
force-pushed
the
escape-request-uri
branch
from
ed84fc7
to
3ce0ad9
Compare
|
I added e2e tests and the CI passed. |
|
/lgtm Thanks @takonomura! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antoineco, takonomura The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Bluston
added a commit
to Bluston/ingress-nginx
that referenced
this pull request
Sep 25, 2019
YenTheFirst
added a commit
to YenTheFirst/oauth2_proxy
that referenced
this pull request
Oct 1, 2019
The current sample configuration for kubernetes ingress demonstrates using the `auth-signin` annotation to redirect a user to oauth2_proxy's signin page. It constructs the link to do so by directly concatenating `$request_uri` as the `rd` parameter, so the sign-in page knows where to send the user after signin is complete. However, this does not work correctly if the original request URI contains multiple query parameters separated by an ampersand, as that ampersand is interpereted as separating query parameters of the `/oauth2/start` URI. For example: If the user requests a URL: https://example.com/foo?q1=v1&q2=v2 they may be redirected to the signin url https://example.com/oauth2/start?rd=https://example.com/foo?q1=v1&q2=v2 and after completing signin, oauth2_proxy will redirect them to https://example.com/foo?q1=v1 nginx-ingress added an $escaped_request_uri variable about a year ago, to help resolve this kind of issue (kubernetes/ingress-nginx#2811)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Escape
$request_urito correct external auth redirectWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
How to reproduce issue:
https://foo.bar.com/?a=b&c=d(without signed in)https://foo.bar.com/?a=b(c=dis out)