Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc log-format: add variables about ingress #2816

Merged

Conversation

vgramer
Copy link
Contributor

@vgramer vgramer commented Jul 19, 2018

What this PR does / why we need it:
Add the missing ingress information variables to the log-format doc.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2018
@vgramer vgramer force-pushed the doc_log_format_add_ingress_info_vars branch from f379de1 to 9024d2f Compare July 19, 2018 15:40
@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #2816 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2816      +/-   ##
==========================================
+ Coverage   47.34%   47.47%   +0.12%     
==========================================
  Files          75       75              
  Lines        5413     5413              
==========================================
+ Hits         2563     2570       +7     
+ Misses       2525     2519       -6     
+ Partials      325      324       -1
Impacted Files Coverage Δ
cmd/nginx/main.go 11.18% <0%> (+4.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496fb9d...9024d2f. Read the comment docs.

@antoineco
Copy link
Contributor

Thanks @vgramer, please sign the CLA.

@vgramer
Copy link
Contributor Author

vgramer commented Jul 19, 2018

@antoineco done :)

@aledbf aledbf closed this Jul 19, 2018
@aledbf aledbf reopened this Jul 19, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 19, 2018
@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, vgramer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9bf919a into kubernetes:master Jul 19, 2018
@vgramer vgramer deleted the doc_log_format_add_ingress_info_vars branch September 10, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants