-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc log-format: add variables about ingress #2816
doc log-format: add variables about ingress #2816
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
f379de1
to
9024d2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
+ Coverage 47.34% 47.47% +0.12%
==========================================
Files 75 75
Lines 5413 5413
==========================================
+ Hits 2563 2570 +7
+ Misses 2525 2519 -6
+ Partials 325 324 -1
Continue to review full report at Codecov.
|
Thanks @vgramer, please sign the CLA. |
@antoineco done :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: antoineco, vgramer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add the missing ingress information variables to the log-format doc.