Use nginx image as base and install go on top #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## master #2827 +/- ##
==========================================
+ Coverage 47.33% 47.34% +0.01%
==========================================
Files 75 75
Lines 5413 5413
==========================================
+ Hits 2562 2563 +1
+ Misses 2527 2525 -2
- Partials 324 325 +1
Continue to review full report at Codecov.
|
aledbf
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
ElvinEfendi
reviewed
Jul 21, 2018
build/Dockerfile
Outdated
| git \ | ||
| libc6-dev \ | ||
| make \ | ||
| wget \ |
There was a problem hiding this comment.
formatting seems to be a bit off?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use the nginx image as base image installing go on top with the missing LUA libraries for testing.
This can simplify and improve LUA testing.
ping @ElvinEfendi