Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug : ingress-class not work . issue: flag --ingress-class not w… #283

Closed
wants to merge 1 commit into from

Conversation

1071496910
Copy link

…ork #269

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@fanhaozzu
Copy link

have been fixed #272

@1071496910
Copy link
Author

#269 is bug is not fix in #272 , this commit fix it

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 45.953% when pulling 6c7a0a4 on 1071496910:master into 9bba947 on kubernetes:master.

@1071496910
Copy link
Author

I signed it!

@fanhaozzu
Copy link

fanhaozzu commented Feb 16, 2017

??#272 can't work?can't fix?

@aledbf
Copy link
Member

aledbf commented Feb 16, 2017

@1071496910 fix merged in master.

@aledbf aledbf closed this Feb 16, 2017
@1071496910
Copy link
Author

i'm wrong , #272 fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants