-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support configuring multi_accept directive via configmap #2896
Conversation
/lgtm |
I'll squash once the build is green |
Codecov Report
@@ Coverage Diff @@
## master #2896 +/- ##
==========================================
- Coverage 47.56% 47.55% -0.01%
==========================================
Files 76 76
Lines 5483 5484 +1
==========================================
Hits 2608 2608
- Misses 2540 2542 +2
+ Partials 335 334 -1
Continue to review full report at Codecov.
|
pushed, thanks @ElvinEfendi ! |
/lgtm Thanks @tomxor ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, tomxor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds the
enable-multi-accept
ConfigMap setting which controls themulti_accept
directive in nginx.conf file, instead of the current hardcoded value. Default is set totrue
.Which issue this PR fixes:
fixes #2684