Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support configuring multi_accept directive via configmap #2896

Merged
merged 1 commit into from
Aug 4, 2018
Merged

support configuring multi_accept directive via configmap #2896

merged 1 commit into from
Aug 4, 2018

Conversation

tomxor
Copy link
Contributor

@tomxor tomxor commented Aug 4, 2018

What this PR does / why we need it:
Adds the enable-multi-accept ConfigMap setting which controls the multi_accept directive in nginx.conf file, instead of the current hardcoded value. Default is set to true.

Which issue this PR fixes:
fixes #2684

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 4, 2018
@ElvinEfendi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 4, 2018
@tomxor
Copy link
Contributor Author

tomxor commented Aug 4, 2018

I'll squash once the build is green

@codecov-io
Copy link

codecov-io commented Aug 4, 2018

Codecov Report

Merging #2896 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2896      +/-   ##
==========================================
- Coverage   47.56%   47.55%   -0.01%     
==========================================
  Files          76       76              
  Lines        5483     5484       +1     
==========================================
  Hits         2608     2608              
- Misses       2540     2542       +2     
+ Partials      335      334       -1
Impacted Files Coverage Δ
internal/ingress/controller/config/config.go 98.27% <100%> (+0.01%) ⬆️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f5d90...b7bcf92. Read the comment docs.

@tomxor
Copy link
Contributor Author

tomxor commented Aug 4, 2018

pushed, thanks @ElvinEfendi !

@ElvinEfendi
Copy link
Member

/lgtm
/approve

Thanks @tomxor !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, tomxor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 38207e8 into kubernetes:master Aug 4, 2018
@tomxor tomxor deleted the multi-accept-cfg branch August 4, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make multi_accept configurable
4 participants