-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] delete unused backend fields #2920
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7f1c119
to
3dad315
Compare
This was added at #716. Maybe at the time it was working and over time someone mistakenly removed its usage, but looking at the code that annotation is not being used. Also it's been deprecated as part #2871, and we should encapsulate it in |
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 47.56% 47.54% -0.03%
==========================================
Files 77 77
Lines 5531 5502 -29
==========================================
- Hits 2631 2616 -15
+ Misses 2560 2550 -10
+ Partials 340 336 -4
Continue to review full report at Codecov.
|
@ElvinEfendi friendly ping |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: