Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] delete unused backend fields #2920

Closed
wants to merge 5 commits into from

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2018
@ElvinEfendi ElvinEfendi force-pushed the dellete-unused-fields branch from 7f1c119 to 3dad315 Compare August 12, 2018 02:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2018
@ElvinEfendi
Copy link
Member Author

secure-verify-ca-secret

This was added at #716. Maybe at the time it was working and over time someone mistakenly removed its usage, but looking at the code that annotation is not being used. Also it's been deprecated as part #2871, and we should encapsulate it in Location type of rather than Backend just like BackendProtocol annotation.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #2920 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
- Coverage   47.56%   47.54%   -0.03%     
==========================================
  Files          77       77              
  Lines        5531     5502      -29     
==========================================
- Hits         2631     2616      -15     
+ Misses       2560     2550      -10     
+ Partials      340      336       -4
Impacted Files Coverage Δ
internal/ingress/types.go 0% <ø> (ø) ⬆️
internal/ingress/types_equals.go 13.35% <ø> (+0.18%) ⬆️
internal/ingress/zz_generated.deepcopy.go 0% <ø> (ø) ⬆️
internal/ingress/controller/nginx.go 11.28% <ø> (-0.4%) ⬇️
...nternal/ingress/annotations/secureupstream/main.go 100% <ø> (+18.18%) ⬆️
internal/ingress/controller/controller.go 2.22% <0%> (+0.02%) ⬆️
internal/ingress/controller/template/template.go 64.83% <100%> (ø) ⬆️
internal/ingress/annotations/annotations.go 77.77% <0%> (-3.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b20058...022dc38. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Oct 11, 2018

@ElvinEfendi friendly ping

@ElvinEfendi ElvinEfendi deleted the dellete-unused-fields branch October 11, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants