Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Troubleshooting Documentation #3002

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

diazjf
Copy link

@diazjf diazjf commented Aug 28, 2018

Enhances the troubleshooting documentation by adding a whole list of basic ways to troubleshoot. Also cleans up previous sections and adds information about the gdb.

Fixes #2952

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2018
Enhances the troubleshooting documentation by adding a whole
list of basic ways to troubleshoot. Also cleans up previous
sections and adds information about the gdb.

Fixes kubernetes#2952
@diazjf diazjf force-pushed the trouble-to-the-shooting branch from 56cdc67 to 145dc50 Compare August 28, 2018 19:22
@codecov-io
Copy link

Codecov Report

Merging #3002 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3002      +/-   ##
==========================================
- Coverage   47.54%   47.52%   -0.02%     
==========================================
  Files          77       77              
  Lines        5639     5639              
==========================================
- Hits         2681     2680       -1     
- Misses       2605     2607       +2     
+ Partials      353      352       -1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cb033...145dc50. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 29, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, diazjf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2018
@aledbf
Copy link
Member

aledbf commented Aug 29, 2018

@diazjf thanks!

@k8s-ci-robot k8s-ci-robot merged commit 7227777 into kubernetes:master Aug 29, 2018
@ElvinEfendi
Copy link
Member

ElvinEfendi commented Aug 29, 2018

@aledbf I thought you included gdb as part of base Nginx image, is that not the case anymore? Why do we have to install it again? #2925 was the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants