do not hardcode the path #3073
Merged
do not hardcode the path #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
hchenxa
force-pushed
the
hchenxa_fix3071
branch
from
d7cf4e5
to
f251190
Compare
k8s-ci-robot
added
size/S
ElvinEfendi
reviewed
Sep 16, 2018
| local s = {} | ||
| cookie.new = function(self) | ||
| local test_backend_hash_fn = test_backend.sessionAffinityConfig.cookieSessionAffinity.hash | ||
| local cookie_instance = { | ||
| set = function(self, payload) | ||
| assert.equal(payload.key, test_backend.sessionAffinityConfig.cookieSessionAffinity.name) | ||
| assert.equal(payload.value, util[test_backend_hash_fn .. "_digest"](test_backend_endpoint)) | ||
| assert.equal(payload.path, "/") | ||
| assert.equal(payload.path, nil) |
There was a problem hiding this comment.
can you mock ngx.var.location_path at
nil?
hchenxa
force-pushed
the
hchenxa_fix3071
branch
from
f251190
to
a0b7a21
Compare
k8s-ci-robot
added
size/M
hchenxa
force-pushed
the
hchenxa_fix3071
branch
from
a0b7a21
to
3dc21ea
Compare
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, hchenxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks for the fix @hchenxa ! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
the path was hardcoded and this PR was to address the issue #3071
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #3071Special notes for your reviewer:
/assign @caseydavenport