-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPT: annotation enhancement for resty-lua-waf #3187
UPT: annotation enhancement for resty-lua-waf #3187
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it |
@DesmondHoLLM please rebase to pass CI |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@aledbf thanks for replying P.S. the cla is marked as failed again after rebase 🤔 |
/check-cla |
@DesmondHoLLM please rebase and squash the commits. The problem should go away after that. |
3409493
to
54d4fe3
Compare
54d4fe3
to
848b795
Compare
@aledbf thanks for reminding |
aa5e438
to
c9ad9c0
Compare
Dear all, added another annotation for work around of this issue: /assign @ElvinEfendi |
b4125e6
to
deb7e21
Compare
c428b64
to
bab521e
Compare
Hi @ElvinEfendi, updated the pr could you please advise, thanks |
94e69b4
to
f50aa5c
Compare
915dd5c
to
bf03046
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DesmondHoLLM, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DesmondHoLLM thanks! |
Dear community,
feature