Avoid reloads when endpoints are not available #3338
Conversation
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
approved
| @@ -70,9 +71,9 @@ var _ = framework.IngressNginxDescribe("Service backend - 503", func() { | |||
|
|
|||
| f.EnsureIngress(bi) | |||
|
|
|||
| f.WaitForNginxServer(host, | |||
| f.WaitForNginxConfiguration( | |||
There was a problem hiding this comment.
because the change in the template means there is no return 503 (we only have the name of the server
There was a problem hiding this comment.
I understand that, I meant WaitForNginxServer > WaitForNginxConfiguration change
There was a problem hiding this comment.
These assertions will pass even without your template changes.
There was a problem hiding this comment.
You could do something like
f.WaitForNginxServer(host,
func(server string) bool {
return strings.Contains(server, "proxy_pass http://upstream_balancer;")
})
k8s-ci-robot
added
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR helps to avoid NGINX reloads when there are no endpoints available or changing too fast (pod restart, something normal in a dev cluster)
fixes #3314 (#3314 (comment))