-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent X-Forwarded-Proto forward during external auth subrequest #3405
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @ElvinEfendi |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, wayt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wayt please sign the CLA |
@aledbf I'm having an issue with the Linux Foundation process, I've contacted them by email to solve this. |
I signed it |
@@ -841,6 +841,7 @@ stream { | |||
|
|||
proxy_pass_request_body off; | |||
proxy_set_header Content-Length ""; | |||
proxy_set_header X-Fowarded-Proto ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wayt I think you have a typo here, it should be X-Forwarded-Proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.... yup
What this PR does / why we need it:
This prevents X-Forwarded-Proto forwarding during external auth sub request.
This cause external auth to return 308 or 301 even if its target url is an hardcoded https.
Which issue this PR fixes
fixes #3389
Special notes for your reviewer: