Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent X-Forwarded-Proto forward during external auth subrequest #3405

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

wayt
Copy link
Contributor

@wayt wayt commented Nov 12, 2018

What this PR does / why we need it:
This prevents X-Forwarded-Proto forwarding during external auth sub request.

This cause external auth to return 308 or 301 even if its target url is an hardcoded https.

Which issue this PR fixes
fixes #3389

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2018
@wayt
Copy link
Contributor Author

wayt commented Nov 12, 2018

/assign @ElvinEfendi

@aledbf
Copy link
Member

aledbf commented Nov 12, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, wayt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2018
@aledbf
Copy link
Member

aledbf commented Nov 12, 2018

@wayt please sign the CLA

@wayt
Copy link
Contributor Author

wayt commented Nov 12, 2018

@aledbf I'm having an issue with the Linux Foundation process, I've contacted them by email to solve this.

@wayt
Copy link
Contributor Author

wayt commented Nov 12, 2018

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 0232611 into kubernetes:master Nov 12, 2018
@wayt wayt deleted the external-auth-proto branch November 12, 2018 20:37
@@ -841,6 +841,7 @@ stream {

proxy_pass_request_body off;
proxy_set_header Content-Length "";
proxy_set_header X-Fowarded-Proto "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wayt I think you have a typo here, it should be X-Forwarded-Proto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[external-auth] unwanted redirect because of X-Forwarded-Proto
4 participants