Fix data size validations

[aledbf]

Which issue this PR fixes: fixes #3468

[ElvinEfendi]

Why don't you just do following?

var sizeUnitRegex = regexp.MustCompile(`^[0-9]+[kKmMgG]$`)

...

return sizeUnitRegex.MatchString(s)

[aledbf]

@ElvinEfendi because that regex does not support passing just numbers "10000"

[ElvinEfendi]

Why not? you can use the following regexp:

^[0-9]+[kKmMgG]{0,1}$

[ElvinEfendi]

also from http://nginx.org/en/docs/syntax.html

Sizes can be specified in bytes, kilobytes (suffixes k and K) or megabytes (suffixes m and M), for example, “1024”, “8k”, “1m”.

why are we adding support for g?

[aledbf]

why are we adding support for g?

Please check #3468

[ElvinEfendi]

I've seen that but the documentation does not say it supports g.

[aledbf]

I've seen that but the documentation does not say it supports g.

Agree but it works 🤔

[ElvinEfendi]

I think we should revert https://github.com/kubernetes/ingress-nginx/pull/3409/files instead of adding g support for this.

Otherwise by merging this PR as is, we would be keeping incorrect behaviour which is worse than incomplete.

[ElvinEfendi]

/lgtm

We can do #3492 (comment) in another PR.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi,aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment