{tcp,udp}-services cm appear twice

[jmervine]

What this PR does / why we need it:

The {tcp,udp}-services ConfigMaps appear twice, while idempotent, it's unnecessary.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jmervine]

I signed it

[aledbf]

/lgtm
/approve

[aledbf]

@jmervine thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, jmervine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

/check-cla

[jmervine]

I signed it

(for real this time)

[jmervine]

@aledbf I just noticed these configmaps are defined yet again in https://github.com/kubernetes/ingress-nginx/blob/master/deploy/configmap.yaml. Shall I remove

ingress-nginx/test/manifests/ingress-controller/mandatory.yaml

Lines 9 to 25 in 5de991b

	---
	kind: ConfigMap
	apiVersion: v1
	metadata:
	name: tcp-services
	labels:
	app.kubernetes.io/name: ingress-nginx
	app.kubernetes.io/part-of: ingress-nginx
	---
	kind: ConfigMap
	apiVersion: v1
	metadata:
	name: udp-services
	labels:
	app.kubernetes.io/name: ingress-nginx
	app.kubernetes.io/part-of: ingress-nginx

as well?

[aledbf]

/check-cla

[aledbf]

I just noticed these configmaps are defined yet again in https://github.com/kubernetes/ingress-nginx/blob/master/deploy/configmap.yaml. Shall I remove

No. The mandatory.yaml file is generated from the other files in the directory with https://github.com/kubernetes/ingress-nginx/blob/master/hack/build-single-manifest-sh

[jmervine]

Gotcha, appears to be a bug then in 0.21.0, as it's missing those configmaps

https://github.com/kubernetes/ingress-nginx/blob/nginx-0.21.0/deploy/mandatory.yaml

[jmervine]

okay, let's try this again

/check-cla