-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dockerfile entrypoint #3536
Conversation
As mentioned in #3535 it looks to me that this patch removes |
Please disregard my previous comment, I didn't read the |
I tested this and it fixes the issue described in #3533 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This changes from #3535 (comment) to:
@breunigs
quay.io/kubernetes-ingress-controller/nginx-ingress-controller:dev
contains this PRBefore merging this change we need to run this PR several days (to make sure we don't introduce zombie processes).
I am already doing this in several clusters. Will check on Monday if everything is working as expected