Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dockerfile entrypoint #3536

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 7, 2018

This changes from #3535 (comment) to:

  PID TTY      STAT   TIME COMMAND
  116 pts/0    Rs+    0:00 ps axf
    1 ?        Ss     0:00 /usr/bin/dumb-init -- /nginx-ingress-controller --def
    6 ?        Ssl    0:00 /nginx-ingress-controller --default-backend-service=i
   30 ?        S      0:00  \_ nginx: master process /usr/sbin/nginx -c /etc/ngi
   50 ?        Sl     0:00      \_ nginx: worker process
   51 ?        Sl     0:00      \_ nginx: worker process

@breunigs quay.io/kubernetes-ingress-controller/nginx-ingress-controller:dev contains this PR

Before merging this change we need to run this PR several days (to make sure we don't introduce zombie processes).
I am already doing this in several clusters. Will check on Monday if everything is working as expected

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@breunigs
Copy link
Contributor

breunigs commented Dec 7, 2018

As mentioned in #3535 it looks to me that this patch removes authbind from the call chain. Is that intended? I don't have a full setup here, but from a quick glance it looks like nginx still runs as www-data in this version. I would thus expect it to fail when it needs to bind low ports. I can double check that on Monday, in case quay.io/kubernetes-ingress-controller/nginx-ingress-controller:dev contains more patches that solve this differently.

@breunigs
Copy link
Contributor

breunigs commented Dec 7, 2018

Please disregard my previous comment, I didn't read the ingress-nginx-controller code closely enough.

@breunigs
Copy link
Contributor

I tested this and it fixes the issue described in #3533

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants