worker_connections should be less (3/4th) than worker_rlimit_nofile #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
|
I think set the worker_connections to 75% of worker_rlimit_nofile is fine |
ElvinEfendi
force-pushed
the
fix-worker-connection-calculation
branch
from
d3fda08
to
22a4132
Compare
ElvinEfendi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
ElvinEfendi
force-pushed
the
fix-worker-connection-calculation
branch
from
22a4132
to
638f965
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When calculated automatically we set
worker_rlimit_nofileandworker_connectionsto the same value. This can be problematic because connections are not the only things using file descriptors. Nginx can be using file descriptors to open temporary files it uses to store cached data, or for serving static asset, or serving compressed data from disk etc.This PR suggest to set the
worker_connectionsto 75% ofworker_rlimit_nofile, but I'm not yet convinced this is the best option. Open for discussion.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: