Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Opentracing with Datadog - part 1 #3767

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Support Opentracing with Datadog - part 1 #3767

merged 1 commit into from
Feb 16, 2019

Conversation

ellieayla
Copy link
Contributor

What this PR does / why we need it: Adds Datadog open tracing library to the Nginx container. This is a prerequisite of PR #3766, pointed out by @aledbf

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes half of #3752

Special notes for your reviewer: See PR #3766 for the configuration-generation half of this change

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2019
@ellieayla
Copy link
Contributor Author

ellieayla commented Feb 15, 2019

e2e tests at https://travis-ci.org/kubernetes/ingress-nginx/jobs/493567349 failed, though I don't see how those failures might relate to this change. If a problem was introduced I would have expected nearly all tests to fail. Though perhaps only those which depended on the container building ok failed. Or those are the phase 2 tests.

@aledbf can you provide some guidance? Did I misunderstand the way I needed to split the PR?

Edit: That test passed. I must have been looking at some other test job 14h ago.

@ellieayla
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 15, 2019
@aledbf
Copy link
Member

aledbf commented Feb 15, 2019

@alanjcastonguay please squash the commits

This commit is part 1 of 2, adding the Datadog Opentracing
module to the nginx container.

Download https://github.com/DataDog/dd-opentracing-cpp and
https://github.com/msgpack/msgpack-c/, build and install both
during build of the quay.io/kubernetes-ingress-controller image.

Bump nginx tag version to 0.77

Fixes half of #3752
@ellieayla
Copy link
Contributor Author

Force-pushed a squashed version of previous commits to alanjcastonguay:feature/datadog-opentracing-part1

@ellieayla
Copy link
Contributor Author

Cool; tests passed on the squashed variant. @aledbf does part 1 look good?

@aledbf
Copy link
Member

aledbf commented Feb 15, 2019

@alanjcastonguay yes, I am building the image to test PR#2

@aledbf
Copy link
Member

aledbf commented Feb 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanjcastonguay, aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit b02d34c into kubernetes:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants