-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Opentracing with Datadog - part 1 #3767
Support Opentracing with Datadog - part 1 #3767
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Edit: That test passed. I must have been looking at some other test job 14h ago. |
/check-cla |
@alanjcastonguay please squash the commits |
This commit is part 1 of 2, adding the Datadog Opentracing module to the nginx container. Download https://github.com/DataDog/dd-opentracing-cpp and https://github.com/msgpack/msgpack-c/, build and install both during build of the quay.io/kubernetes-ingress-controller image. Bump nginx tag version to 0.77 Fixes half of #3752
Force-pushed a squashed version of previous commits to alanjcastonguay:feature/datadog-opentracing-part1 |
Cool; tests passed on the squashed variant. @aledbf does part 1 look good? |
@alanjcastonguay yes, I am building the image to test PR#2 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanjcastonguay, aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Adds Datadog open tracing library to the Nginx container. This is a prerequisite of PR #3766, pointed out by @aledbf
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes half of #3752Special notes for your reviewer: See PR #3766 for the configuration-generation half of this change