Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Lua tracing #3783

Closed
wants to merge 3 commits into from
Closed

[wip] Lua tracing #3783

wants to merge 3 commits into from

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@ElvinEfendi
Copy link
Member Author

I see

2019/02/20 14:40:54 [error] 42#42: *374 failed to expand opentracing_context_ for request 0000564FD8E6D060: no OpenTracingContext attached to request, client: 172.17.0.1, server: example.com, request: "GET /echo HTTP/1.1", host: "example.com"
2019/02/20 14:40:54 [warn] 42#42: *374 [lua] balancer.lua:224: trace_function(): ngx.var.opentracing_binary_context is empty, client: 172.17.0.1, server: example.com, request: "GET /echo HTTP/1.1", host: "example.com"

in the logs for my example app, this happens in rewrite phase where opentracing hasn't run yet, it creates opentracing context only at preaccess phase, which is after rewrite: https://github.com/opentracing-contrib/nginx-opentracing/blob/9cde691471eee8152484462f748486f595007464/opentracing/src/ngx_http_opentracing_module.cpp#L172

@ElvinEfendi
Copy link
Member Author

But it does work for anything after preaccess phase and looks like

screen shot 2019-02-20 at 9 48 20 am

@@ -121,7 +121,7 @@ else
$(SED_I) "s/CROSS_BUILD_//g" $(DOCKERFILE)
endif

$(DOCKER) build --no-cache --pull -t $(MULTI_ARCH_IMG):$(TAG) $(TEMP_DIR)/rootfs
$(DOCKER) build --no-cache -t $(MULTI_ARCH_IMG):$(TAG) $(TEMP_DIR)/rootfs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this, this is only so that I can use locally build base image using

BASEIMAGE=quay.io/kubernetes-ingress-controller/nginx-amd64:0.78 make dev-env

where I built quay.io/kubernetes-ingress-controller/nginx-amd64:0.78 locally based on #3782

@aledbf
Copy link
Member

aledbf commented Mar 4, 2019

@ElvinEfendi what's missing to merge the PR?

@ElvinEfendi
Copy link
Member Author

@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2019
@ElvinEfendi
Copy link
Member Author

Now that opentracing-contrib/nginx-opentracing#98 is merged, I'm going to resume this work to see if that helps.

@aledbf
Copy link
Member

aledbf commented Jun 6, 2019

@ElvinEfendi did you test this with the new image?

@k8s-ci-robot
Copy link
Contributor

@ElvinEfendi: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-nginx-e2e-1-15 ef9d96b link /test pull-ingress-nginx-e2e-1-15
pull-ingress-nginx-lualint ef9d96b link /test pull-ingress-nginx-lualint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 7, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2019
@k8s-ci-robot
Copy link
Contributor

@ElvinEfendi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf aledbf mentioned this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants