-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Lua tracing #3783
[wip] Lua tracing #3783
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I see
in the logs for my example app, this happens in rewrite phase where opentracing hasn't run yet, it creates opentracing context only at preaccess phase, which is after rewrite: https://github.com/opentracing-contrib/nginx-opentracing/blob/9cde691471eee8152484462f748486f595007464/opentracing/src/ngx_http_opentracing_module.cpp#L172 |
@@ -121,7 +121,7 @@ else | |||
$(SED_I) "s/CROSS_BUILD_//g" $(DOCKERFILE) | |||
endif | |||
|
|||
$(DOCKER) build --no-cache --pull -t $(MULTI_ARCH_IMG):$(TAG) $(TEMP_DIR)/rootfs | |||
$(DOCKER) build --no-cache -t $(MULTI_ARCH_IMG):$(TAG) $(TEMP_DIR)/rootfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert this, this is only so that I can use locally build base image using
BASEIMAGE=quay.io/kubernetes-ingress-controller/nginx-amd64:0.78 make dev-env
where I built quay.io/kubernetes-ingress-controller/nginx-amd64:0.78
locally based on #3782
@ElvinEfendi what's missing to merge the PR? |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Now that opentracing-contrib/nginx-opentracing#98 is merged, I'm going to resume this work to see if that helps. |
@ElvinEfendi did you test this with the new image? |
@ElvinEfendi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@ElvinEfendi: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: