-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "Sticky session" docs #3841
Improve "Sticky session" docs #3841
Conversation
@shroudedcode please rebase and squash the commits |
688a620
to
fb55864
Compare
while I agree this is more readable but IMO it's less useful - users usually don't want to read the whole document and just copy paste - having the prefix together with annotation name is useful. Also this is the set standard everywhere else in the user guide. I'd rather not change that. |
0165fe6
to
ec72470
Compare
@shroudedcode thanks a lot! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, shroudedcode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think it needs to have better docs for sticky session, was just about to make a thread regarding the issue. Im not sure on how to write |
@WStasW The Here's an example using apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: example
annotations:
nginx.ingress.kubernetes.io/affinity: cookie
nginx.ingress.kubernetes.io/session-cookie-path: /
nginx.ingress.kubernetes.io/rewrite-target: /$1
spec:
rules:
- host: example.com
http:
paths:
- path: /(.*)
backend:
serviceName: example
servicePort: 80 |
What this PR does / why we need it:
This PR makes it easier for people who want to set up sticky sessions to find the information they need.
Changes:
session-cookie-path
annotation (I spent way too much time trying to find this)code highlighting
)make table more readable by removing prefix from table cells