-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic SSL certificate for aliases and redirect-from-to-www #3932
Conversation
Why is this not caught by e2e tests? No e2e test for redirect to and alias? Can we add one for each? |
@ElvinEfendi done. Not sure if all these new dependencies makes sense but we need to resolve the addresses we are using and being redirected to. |
@aledbf why do you need to resolve? |
|
I changed the e2e test to use |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
When dynamic SSL certificates is enabled we need to configure the aliases and redirect-from-to-www hosts with the proper certificate or NGINX will return the fake one
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: