Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic SSL certificate for aliases and redirect-from-to-www #3932

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 26, 2019

What this PR does / why we need it:

When dynamic SSL certificates is enabled we need to configure the aliases and redirect-from-to-www hosts with the proper certificate or NGINX will return the fake one

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2019
@ElvinEfendi
Copy link
Member

Why is this not caught by e2e tests? No e2e test for redirect to and alias? Can we add one for each?

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2019
@aledbf
Copy link
Member Author

aledbf commented Mar 28, 2019

@ElvinEfendi done. Not sure if all these new dependencies makes sense but we need to resolve the addresses we are using and being redirected to.

@ElvinEfendi
Copy link
Member

@aledbf why do you need to resolve?

@aledbf
Copy link
Member Author

aledbf commented Mar 28, 2019

why do you need to resolve?

Because of the redirect. Without that we get a dns error resolving the hostname

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2019
@aledbf
Copy link
Member Author

aledbf commented Mar 28, 2019

I changed the e2e test to use nip.io to avoid adding all those dns dependencies. If this solution is flaky, we can revisit and try another approach

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7e21a2d into kubernetes:master Mar 28, 2019
@aledbf aledbf deleted the fix-alias-ssl branch March 29, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants