Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review docs #408

Merged
merged 1 commit into from
Mar 10, 2017
Merged

Review docs #408

merged 1 commit into from
Mar 10, 2017

Conversation

gianrubio
Copy link
Contributor

  • Fix broken links
  • Upgrade all nginx examples to latest version
  • Moved some examples from contrib to this repo

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2017
@k8s-reviewable
Copy link

This change is Reviewable

aledbf
aledbf reviewed Mar 8, 2017
View reviewed changes
controllers/nginx/Changelog.md Outdated
@@ -48,7 +48,7 @@ Changelog

### 0.9-beta.1

**Image:** `gcr.io/google_containers/nginx-ingress-controller:0.9.0-beta.1`
**Image:** `gcr.io/google_containers/nginx-ingress-controller:0.9.0-beta.2`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is beta 1 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :)

@gianrubio
fix some broken links
a2edde3 
upgrade all nginx examples to latest version
moved some examples from contrib to this repo
@aledbf
Copy link
Member

aledbf commented Mar 8, 2017

@gianrubio in some examples the directory nginx is missing

@gianrubio
Copy link
Contributor Author

@aledbf hum you're right, let me fix that.

@gianrubio
Copy link
Contributor Author

@aledbf what about generic docs same as https://github.com/gianrubio/ingress/blob/a2edde35fc0cd0d59cceea4cafbe00d4f419c4ff/examples/rewrite/README.md? Is it necessary to split into a nginx folder?

@aledbf
Copy link
Member

aledbf commented Mar 8, 2017

Is it necessary to split into a nginx folder?

yes because we cannot assume the features provided by other implementations

@coveralls
Copy link

Coverage Status

Coverage remained the same at 45.915% when pulling a2edde3 on gianrubio:fix-links into 4c0a616 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 45.933% when pulling a2edde3 on gianrubio:fix-links into 4c0a616 on kubernetes:master.

@aledbf aledbf self-assigned this Mar 10, 2017
@aledbf
Copy link
Member

aledbf commented Mar 10, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2017
@aledbf aledbf merged commit dd7f8b4 into kubernetes:master Mar 10, 2017
@aledbf
Copy link
Member

aledbf commented Mar 10, 2017

@gianrubio thanks!

@aledbf aledbf mentioned this pull request Mar 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gianrubio @k8s-reviewable @aledbf @coveralls @k8s-ci-robot