v1beta1: Update all controllers to use networking.k8s.io/v1beta1

[cmluciano]

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Migrates all controllers and code to target the new networking.k8s.io/v1 APIs

Which issue(s) this PR fixes:
Related: kubernetes/enhancements#758

Special notes for your reviewer:

• I'm hoping that I hit all of the variations, but it's possible that something got missed.
• I will update all examples in a follow-up PR

Does this PR introduce a user-facing change?:
-->

ingress:  Update in-tree Ingress controllers, and clients to target networking.k8s.io/v1beta1

[aledbf]

I will update all examples in a follow-up PR

Please wait for that after #4055

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cmluciano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aledbf

If they are not already assigned, you can assign the PR to them by writing /assign @aledbf in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cmluciano]

I'm having trouble with some test cases that might be related to a missed make step. Any ideas on this?

=== RUN   TestStore
=== RUN   TestStore/should_return_an_error_searching_for_non_existing_objects
=== RUN   TestStore/should_return_one_event_for_add,_update_and_delete_of_ingress
=== RUN   TestStore/should_not_receive_updates_for_ingress_with_invalid_class
=== RUN   TestStore/should_not_receive_events_from_secret_not_referenced_from_ingress
=== RUN   TestStore/should_receive_events_from_secret_referenced_from_ingress
=== RUN   TestStore/should_create_an_ingress_with_a_secret_which_does_not_exist
=== RUN   TestStore/should_create_an_ingress_with_a_secret_which_does_not_exist/should_exists_a_secret_in_the_local_store_and_filesystem
E0514 15:18:20.285355     611 file.go:31] Error reading file open /etc/ingress-controller/ssl/store-test-ingress-with-secret.pem: no such file or directory
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1994b08]

goroutine 401 [running]:
testing.tRunner.func1(0xc00064b600)
	/usr/local/go/src/testing/testing.go:830 +0x69d
panic(0x1af21c0, 0x2dc6b30)
	/usr/local/go/src/runtime/panic.go:522 +0x1b5
k8s.io/ingress-nginx/internal/ingress/controller/store.TestStore.func6.2(0xc00064b600)
	/go/src/k8s.io/ingress-nginx/internal/ingress/controller/store/store_test.go:729 +0x438
testing.tRunner(0xc00064b600, 0xc00058f090)
	/usr/local/go/src/testing/testing.go:865 +0x164
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:916 +0x65b
FAIL	k8s.io/ingress-nginx/internal/ingress/controller/store	31.975s

[aledbf]

@cmluciano I can reproduce this locally. Using k8s/testing_framework to use a real apiserver in the test df35990 and I get decoding errors

=== RUN   TestStore
=== RUN   TestStore/should_return_an_error_searching_for_non_existing_objects
I0515 10:30:42.109355   10919 event.go:258] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"store-test-1557930642", Name:"config", UID:"0493a755-771e-11e9-84ec-0028f8260615", APIVersion:"v1", ResourceVersion:"42", FieldPath:""}): type: 'Normal' reason: 'CREATE' ConfigMap store-test-1557930642/config
=== RUN   TestStore/should_return_one_event_for_add,_update_and_delete_of_ingress
I0515 10:30:43.902657   10919 event.go:258] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"store-test-1557930643", Name:"config", UID:"054da005-771e-11e9-84ec-0028f8260615", APIVersion:"v1", ResourceVersion:"47", FieldPath:""}): type: 'Normal' reason: 'CREATE' ConfigMap store-test-1557930643/config
=== RUN   TestStore/should_not_receive_updates_for_ingress_with_invalid_class
I0515 10:30:45.702543   10919 event.go:258] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"store-test-1557930645", Name:"config", UID:"0656fdf1-771e-11e9-84ec-0028f8260615", APIVersion:"v1", ResourceVersion:"52", FieldPath:""}): type: 'Normal' reason: 'CREATE' ConfigMap store-test-1557930645/config
=== RUN   TestStore/should_not_receive_events_from_secret_not_referenced_from_ingress
I0515 10:30:48.302553   10919 event.go:258] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"store-test-1557930647", Name:"config", UID:"07a20437-771e-11e9-84ec-0028f8260615", APIVersion:"v1", ResourceVersion:"57", FieldPath:""}): type: 'Normal' reason: 'CREATE' ConfigMap store-test-1557930647/config
=== RUN   TestStore/should_receive_events_from_secret_referenced_from_ingress
I0515 10:30:50.716687   10919 event.go:258] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"store-test-1557930650", Name:"config", UID:"09b2f49d-771e-11e9-84ec-0028f8260615", APIVersion:"v1", ResourceVersion:"64", FieldPath:""}): type: 'Normal' reason: 'CREATE' ConfigMap store-test-1557930650/config
=== RUN   TestStore/should_create_an_ingress_with_a_secret_which_does_not_exist
I0515 10:30:53.102568   10919 event.go:258] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"store-test-1557930652", Name:"config", UID:"0abb7d35-771e-11e9-84ec-0028f8260615", APIVersion:"v1", ResourceVersion:"70", FieldPath:""}): type: 'Normal' reason: 'CREATE' ConfigMap store-test-1557930652/config
I0515 10:30:54.658816   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.658907   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.658949   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.658912   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
W0515 10:30:54.659000   10919 reflector.go:302] k8s.io/ingress-nginx/internal/ingress/controller/store/store.go:176: watch of *v1beta1.Ingress ended with: very short watch: k8s.io/ingress-nginx/internal/ingress/controller/store/store.go:176: Unexpected watch close - watch lasted less than a second and no items received
I0515 10:30:54.659062   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.659066   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.659157   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.659164   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.659234   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.659244   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.659302   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.658910   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.659449   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF
I0515 10:30:54.658921   10919 streamwatcher.go:114] Unexpected EOF during watch stream event decoding: unexpected EOF

Maybe this is an issue with networking.k8s.io/v1beta1?

[cmluciano]

Thanks @aledbf I'll take a look at the client-go stuff to see if there is a weird inconsistency.

[aledbf]

/hold

[aledbf]

@cmluciano let me merge #4088 before trying to get this working. With that we can verify this change will not break in k8s < 1.14

[aledbf]

/retest

[k8s-ci-robot]

@cmluciano: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-ingress-nginx-test	9b49f92	link	/test pull-ingress-nginx-test
pull-ingress-nginx-e2e-1-13	9b49f92	link	/test pull-ingress-nginx-e2e-1-13
pull-ingress-nginx-e2e-1-14	9b49f92	link	/test pull-ingress-nginx-e2e-1-14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[aledbf]

@cmluciano please wait, do not continue changing the PR. We cannot switch everything to networking. That would mean we break old clusters (< 1.14.0).

[k8s-ci-robot]

@cmluciano: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cmluciano]

Closing in favor of #4127