Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configmap about adding custom locations #4098

Merged
merged 1 commit into from
May 18, 2019

Conversation

kevinsimper
Copy link
Contributor

I tried using server-snippet and location-snippet to add a custom location, like this in 0.24.1:

  location-snippet: |
    allow 20.0.0.0/8;
    deny all;

    location /status {
        allow 100.0.0.0/8;
        deny all;

        set $proxy_upstream_name "{{ buildUpstreamName $server.Hostname $all.Backends $location $all.DynamicConfigurationEnabled }}";
        proxy_pass http://upstream_balancer;
    }

but that didn't work, I got 503, and I tried copying in the exact location, but then the nginx configuration doesn't load, and the last solution was to make my own nginx.tmpl and that worked.

It looks like others also have experienced the same and this feature has stopped working: #4084 (comment)

It would be cool if you could avoid having to inherit the whole nginx.tmpl., but it is not bad, but it is just a bit of inconvenience to have to try the whole ordeal by providing your small customization with a location snippet and then debugging 😃

@k8s-ci-robot
Copy link
Contributor

Welcome @kevinsimper!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kevinsimper. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2019
@aledbf
Copy link
Member

aledbf commented May 18, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2019
@aledbf
Copy link
Member

aledbf commented May 18, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2019
@aledbf
Copy link
Member

aledbf commented May 18, 2019

@kevinsimper thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, kevinsimper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2019
@aledbf
Copy link
Member

aledbf commented May 18, 2019

/retest

@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1bd3fd2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4098   +/-   ##
=========================================
  Coverage          ?   57.72%           
=========================================
  Files             ?       87           
  Lines             ?     6450           
  Branches          ?        0           
=========================================
  Hits              ?     3723           
  Misses            ?     2297           
  Partials          ?      430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bd3fd2...ddc2ce5. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit c12059b into kubernetes:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants