-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run PodSecurityPolicy E2E test in parallel #4133
Run PodSecurityPolicy E2E test in parallel #4133
Conversation
Hi @nicknovitski. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nicknovitski please don't change the |
Previously, this test modified a ClusterRole used by _every_ test. It had to be run serially, with a special teardown function that restored the state of the ClusterRole for any other serial tests. Now every test gets its own cluster role, which means this test can be safely run in parallel with all the others, without any special teardown.
28652bb
to
e1958b8
Compare
Sure, I can see the benefit of that. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4133 +/- ##
==========================================
+ Coverage 57.76% 57.79% +0.03%
==========================================
Files 87 87
Lines 6459 6459
==========================================
+ Hits 3731 3733 +2
+ Misses 2296 2295 -1
+ Partials 432 431 -1
Continue to review full report at Codecov.
|
/lgtm |
@nicknovitski thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, nicknovitski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Previously, this test modified a ClusterRole used by every test. It had to be run serially, with a special teardown function that restored the state of the ClusterRole for any other serial tests.
Now (with #4055), every test gets its own cluster role, which means this test can be safely run in parallel with all the others, without any special teardown.
Also, since it was the only test which required serial execution, we can delete the
ginkgo -focus "[Serial]"
step.