Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PodSecurityPolicy E2E test in parallel #4133

Merged
merged 1 commit into from
May 29, 2019

Conversation

nicknovitski
Copy link
Contributor

@nicknovitski nicknovitski commented May 29, 2019

Previously, this test modified a ClusterRole used by every test. It had to be run serially, with a special teardown function that restored the state of the ClusterRole for any other serial tests.

Now (with #4055), every test gets its own cluster role, which means this test can be safely run in parallel with all the others, without any special teardown.

Also, since it was the only test which required serial execution, we can delete the ginkgo -focus "[Serial]" step.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nicknovitski. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2019
@aledbf
Copy link
Member

aledbf commented May 29, 2019

@nicknovitski please don't change the test/e2e-image/e2e.sh script. Revert that and this LGTM

Previously, this test modified a ClusterRole used by _every_ test.  It had to be run serially, with a special teardown function that restored the state of the ClusterRole for any other serial tests.

Now every test gets its own cluster role, which means this test can be safely run in parallel with all the others, without any special teardown.
@nicknovitski nicknovitski force-pushed the parallel-psp-e2e-test branch from 28652bb to e1958b8 Compare May 29, 2019 21:14
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2019
@nicknovitski
Copy link
Contributor Author

Sure, I can see the benefit of that.

@aledbf
Copy link
Member

aledbf commented May 29, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2019
@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #4133 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4133      +/-   ##
==========================================
+ Coverage   57.76%   57.79%   +0.03%     
==========================================
  Files          87       87              
  Lines        6459     6459              
==========================================
+ Hits         3731     3733       +2     
+ Misses       2296     2295       -1     
+ Partials      432      431       -1
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 90.42% <0%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf11e2e...e1958b8. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented May 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
@aledbf
Copy link
Member

aledbf commented May 29, 2019

@nicknovitski thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, nicknovitski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 85842ed into kubernetes:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants