-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes on timeouts while using long GRPC streams #4228
Conversation
GRPC streams longer than 60s hit multiple timeouts that NGINX has defined. Not all of them are easy to find, so I added some notes to the GRPC example to warn users of setting the correct timeouts if the wish their stream to not be aborted after 60 seconds.
Welcome @roemba! |
Hi @roemba. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4228 +/- ##
=========================================
Coverage ? 57.95%
=========================================
Files ? 87
Lines ? 6536
Branches ? 0
=========================================
Hits ? 3788
Misses ? 2320
Partials ? 428 Continue to review full report at Codecov.
|
/lgtm |
@roemba thanks! |
/assign @aledbf |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, roemba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
GRPC streams longer than 60s hit multiple timeouts that NGINX has defined. Not all of them are as clear for a user to find (do not show clearly in NGINX debug logs), so I added some notes to the GRPC example to warn users of setting the correct timeouts if they wish their stream to not be aborted after 60 seconds.
Which issue this PR fixes:
No specific issue, more fixing of missing information in the documentation.
Special notes for your reviewer: