Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing dot #4274

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Support trailing dot #4274

merged 2 commits into from
Jul 4, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes ##4243

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei July 4, 2019 22:41
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #4274 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4274      +/-   ##
==========================================
- Coverage    58.2%   57.99%   -0.21%     
==========================================
  Files          87       87              
  Lines        6493     6530      +37     
==========================================
+ Hits         3779     3787       +8     
- Misses       2284     2311      +27     
- Partials      430      432       +2
Impacted Files Coverage Δ
internal/ingress/controller/store/backend_ssl.go 41.5% <0%> (-15.07%) ⬇️
cmd/nginx/flags.go 88.5% <0%> (-1.03%) ⬇️
internal/ingress/controller/nginx.go 29.12% <0%> (-0.1%) ⬇️
internal/ingress/controller/controller.go 46.62% <0%> (ø) ⬆️
internal/ingress/controller/config/config.go 98.56% <0%> (ø) ⬆️
internal/net/ssl/ssl.go 50.18% <0%> (+0.18%) ⬆️
internal/ingress/controller/store/store.go 61.26% <0%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf2b03...08906ef. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jul 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 17d99c4 into kubernetes:master Jul 4, 2019
@ElvinEfendi ElvinEfendi deleted the support-trailing-dot branch July 4, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants