Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to oauth2_proxy #4329

Merged

Conversation

steakunderscore
Copy link
Contributor

What this PR does / why we need it:

The custodian of the project has been shifted from bitly to pusher.
So this diff updates these references.

Which issue this PR fixes
None, didn't open an issue as it's a small docs change.

Special notes for your reviewer:

The custodian of the project has been shifted from [bitly] to [pusher].
So this diff updates these references.

[bitly]: https://github.com/bitly/oauth2_proxy
[pusher]: https://github.com/pusher/oauth2_proxy
@k8s-ci-robot
Copy link
Contributor

Welcome @steakunderscore!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @steakunderscore. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2019
@steakunderscore
Copy link
Contributor Author

/assign @bowei

@aledbf
Copy link
Member

aledbf commented Jul 18, 2019

@steakunderscore please don' assign PRs manually.

@aledbf
Copy link
Member

aledbf commented Jul 18, 2019

@steakunderscore have you tested the new image with the instructions from the example?

@steakunderscore
Copy link
Contributor Author

Hi @aledbf. Sorry for the delay. Just tested this and can confirm it works as expected.

@aledbf
Copy link
Member

aledbf commented Aug 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2019
@aledbf
Copy link
Member

aledbf commented Aug 1, 2019

@steakunderscore thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, steakunderscore

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@589c9a2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4329   +/-   ##
=========================================
  Coverage          ?   58.65%           
=========================================
  Files             ?       88           
  Lines             ?     6569           
  Branches          ?        0           
=========================================
  Hits              ?     3853           
  Misses            ?     2286           
  Partials          ?      430

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589c9a2...b8cedab. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 292aca7 into kubernetes:master Aug 1, 2019
@steakunderscore steakunderscore deleted the update-oauth2_proxy-docs branch August 1, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants