-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort ingress by namespace and name when ingress.CreationTimestamp identical #4409
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @ProNic-QY. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ProNic-QY please don't assign PRs manually |
Also, please sign the CLA |
I signed it |
/ok-to-test |
d71a9dc
to
dce398f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4409 +/- ##
=========================================
Coverage ? 59.78%
=========================================
Files ? 89
Lines ? 7020
Branches ? 0
=========================================
Hits ? 4197
Misses ? 2389
Partials ? 434
Continue to review full report at Codecov.
|
/lgtm |
/hold |
@aledbf Why remove this PR from 0.26.0? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi, ProNic-QY The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Because
store.ListIngresses()
sort Ingresses using the CreationTimestamp field ands.listers.IngressWithAnnotation.List()
usemap
as backend cache , So when the list contains more than one Ingress with the same creationTimestamp, the sorting results are unstable.For the reasons mentioned above, the output of
Server.rootLocation
logic will be equally unstable, resulting in slight differences innginx.conf
generated each time, triggering repeated meaningless nginx reload.Server.rootLocation
generate incontroller.createServers()
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: