Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic TLS records #4418

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 8, 2019

What this PR does / why we need it:

This feature was removed in #2290 because the patch was invalid for newer NGINX versions

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4417

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2019
@aledbf
Copy link
Member Author

aledbf commented Aug 8, 2019

/test pull-ingress-nginx-test

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Aug 8, 2019

/test pull-ingress-nginx-test

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member Author

aledbf commented Aug 8, 2019

/retest

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f467876). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4418   +/-   ##
=========================================
  Coverage          ?   58.72%           
=========================================
  Files             ?       88           
  Lines             ?     6593           
  Branches          ?        0           
=========================================
  Hits              ?     3872           
  Misses            ?     2290           
  Partials          ?      431
Impacted Files Coverage Δ
internal/ingress/controller/config/config.go 98.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f467876...4a9b02b. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Aug 8, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit f5148d2 into kubernetes:master Aug 8, 2019
@aledbf aledbf deleted the dynamic-ssl branch August 8, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable-dynamic-tls-records: "false" doesn't work
4 participants