-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dynamic TLS records #4418
Conversation
/test pull-ingress-nginx-test |
1 similar comment
/test pull-ingress-nginx-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov Report
@@ Coverage Diff @@
## master #4418 +/- ##
=========================================
Coverage ? 58.72%
=========================================
Files ? 88
Lines ? 6593
Branches ? 0
=========================================
Hits ? 3872
Misses ? 2290
Partials ? 431
Continue to review full report at Codecov.
|
/retest |
What this PR does / why we need it:
This feature was removed in #2290 because the patch was invalid for newer NGINX versions
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #4417Special notes for your reviewer: