Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move listen logic to go #4439

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Move listen logic to go #4439

merged 1 commit into from
Aug 13, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 13, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #4439 into master will increase coverage by 0.15%.
The diff coverage is 61.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4439      +/-   ##
==========================================
+ Coverage   58.67%   58.83%   +0.15%     
==========================================
  Files          88       88              
  Lines        6582     6695     +113     
==========================================
+ Hits         3862     3939      +77     
- Misses       2291     2312      +21     
- Partials      429      444      +15
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 80.5% <61.7%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016219d...2ed75b3. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Aug 13, 2019

/test pull-ingress-nginx-test

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c4930c9 into kubernetes:master Aug 13, 2019
@aledbf aledbf deleted the listen branch August 13, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants