Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post data to Lua only if it changes #4451

Merged
merged 1 commit into from
Aug 15, 2019
Merged

post data to Lua only if it changes #4451

merged 1 commit into from
Aug 15, 2019

Conversation

ElvinEfendi
Copy link
Member

@ElvinEfendi ElvinEfendi commented Aug 15, 2019

What this PR does / why we need it:

Currently we POST all dynamic data to Lua if even only one of them changes. This PR makes sure we POST only when necessary.

The PR also makes test stricter to assert request is actually being sent.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2019
@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5d6f8c1). Click here to learn what that means.
The diff coverage is 62.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4451   +/-   ##
=========================================
  Coverage          ?   58.89%           
=========================================
  Files             ?       87           
  Lines             ?     6669           
  Branches          ?        0           
=========================================
  Hits              ?     3928           
  Misses            ?     2316           
  Partials          ?      425
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 47.2% <0%> (ø)
internal/ingress/controller/nginx.go 29.22% <63.63%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d6f8c1...05c8893. Read the comment docs.

@ElvinEfendi ElvinEfendi changed the title [wip] post data to Lua only if it changes post data to Lua only if it changes Aug 15, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2019
@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ElvinEfendi
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4b0aabc into kubernetes:master Aug 15, 2019
@ElvinEfendi ElvinEfendi deleted the avoid-redundant-lua-sync branch August 16, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants