Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP: availability zone aware routing #4455

Merged
merged 1 commit into from
Aug 16, 2019
Merged

KEP: availability zone aware routing #4455

merged 1 commit into from
Aug 16, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2019
aledbf
aledbf reviewed Aug 15, 2019
View reviewed changes
docs/enhancements/20190815-zone-aware-routing.md Outdated

## Motivation

When users run their services across multiple availability zones they usually pay for egress traffic between zones. Providers such as GCP, Amazon EC charges money for that.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EC ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant EC2, fixing

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

@ElvinEfendi how this feature will be enabled? A flag in the deployment?

@ElvinEfendi
Copy link
Member Author

@ElvinEfendi how this feature will be enabled? A flag in the deployment?

I'll address this in the subsequent PRs where I add "Proposal" section.

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

Link to a relevant issue #3872

@codecov-io
Copy link

codecov-io commented Aug 15, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@4b0aabc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4455   +/-   ##
=========================================
  Coverage          ?   58.85%           
=========================================
  Files             ?       87           
  Lines             ?     6669           
  Branches          ?        0           
=========================================
  Hits              ?     3925           
  Misses            ?     2319           
  Partials          ?      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b0aabc...d9de505. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ElvinEfendi
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit f0383c6 into kubernetes:master Aug 16, 2019
@ElvinEfendi ElvinEfendi deleted the zone-aware-routing-kep branch August 16, 2019 03:29
@ElvinEfendi ElvinEfendi mentioned this pull request Aug 16, 2019
Merged
@jsoref jsoref mentioned this pull request Mar 9, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@bowei bowei Awaiting requested review from bowei

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElvinEfendi @aledbf @codecov-io @k8s-ci-robot