Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ingress status IP address #4490

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 25, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

fixes #4461
replaces #4462

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2019
@aledbf
Copy link
Member Author

aledbf commented Aug 25, 2019

/retest

@codecov-io
Copy link

Codecov Report

Merging #4490 into master will increase coverage by 0.07%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4490      +/-   ##
==========================================
+ Coverage   59.03%   59.11%   +0.07%     
==========================================
  Files          89       89              
  Lines        6748     6756       +8     
==========================================
+ Hits         3984     3994      +10     
  Misses       2335     2335              
+ Partials      429      427       -2
Impacted Files Coverage Δ
internal/ingress/status/status.go 71.97% <92.59%> (+3.51%) ⬆️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6ce57...62723b9. Read the comment docs.

@harmjanblok
Copy link

Not only services of Type LoadBalancer might have externalIPs, services of Type ClusterIP can have this as well. See https://kubernetes.io/docs/concepts/services-networking/service/#external-ips. I'll see if I can create a PR to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginx-ingress unable to publish endpoints to ingress when using ClusterIP type controller service
4 participants