-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backward compatibility for k8s version < 1.14 #4521
backward compatibility for k8s version < 1.14 #4521
Conversation
Welcome @johnlanni! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @johnlanni. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
925245d
to
3dc8211
Compare
I signed it |
1 similar comment
I signed it |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4521 +/- ##
=========================================
Coverage ? 59.19%
=========================================
Files ? 89
Lines ? 6781
Branches ? 0
=========================================
Hits ? 4014
Misses ? 2334
Partials ? 433
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, johnlanni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-ingress-nginx-e2e-1-13 |
1 similar comment
/test pull-ingress-nginx-e2e-1-13 |
What this PR does / why we need it:
It fixes a bug of Admission Validating Webhook not working when k8s version < 1.14
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #4468Special notes for your reviewer: