-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relative links #4522
Fix relative links #4522
Conversation
Hi @webwurst. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: webwurst The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4522 +/- ##
=========================================
Coverage ? 59.15%
=========================================
Files ? 89
Lines ? 6780
Branches ? 0
=========================================
Hits ? 4011
Misses ? 2335
Partials ? 434 Continue to review full report at Codecov.
|
/retest |
@webwurst: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The links in the last paragraph of https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#rate-limiting don't work as intended. I took over the format from a working link, not totally sure if that is the right way. Feel free to adjust or discard this pull request.