Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative links #4522

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix relative links #4522

merged 1 commit into from
Sep 3, 2019

Conversation

webwurst
Copy link
Contributor

@webwurst webwurst commented Sep 2, 2019

The links in the last paragraph of https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/#rate-limiting don't work as intended. I took over the format from a working link, not totally sure if that is the right way. Feel free to adjust or discard this pull request.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @webwurst. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: webwurst
To complete the pull request process, please assign bowei
You can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2019
@aledbf
Copy link
Member

aledbf commented Sep 3, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1c42362). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4522   +/-   ##
=========================================
  Coverage          ?   59.15%           
=========================================
  Files             ?       89           
  Lines             ?     6780           
  Branches          ?        0           
=========================================
  Hits              ?     4011           
  Misses            ?     2335           
  Partials          ?      434

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c42362...2c09fee. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Sep 3, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 3, 2019

@webwurst: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-nginx-e2e-1-13 2c09fee link /test pull-ingress-nginx-e2e-1-13

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aledbf aledbf merged commit d7dc7be into kubernetes:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants