Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubectl-plugin docs #4582

Merged
merged 1 commit into from
Sep 22, 2019
Merged

Update kubectl-plugin docs #4582

merged 1 commit into from
Sep 22, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 22, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2019
@aledbf
Copy link
Member Author

aledbf commented Sep 22, 2019

/retest

@codecov-io
Copy link

Codecov Report

Merging #4582 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4582      +/-   ##
=========================================
- Coverage   58.61%   58.6%   -0.02%     
=========================================
  Files          88      88              
  Lines        6701    6701              
=========================================
- Hits         3928    3927       -1     
+ Misses       2340    2339       -1     
- Partials      433     435       +2
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 88.29% <0%> (-2.13%) ⬇️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ed6db...bea75a0. Read the comment docs.

@aledbf aledbf merged commit ba38153 into kubernetes:master Sep 22, 2019
@aledbf aledbf deleted the docs2 branch September 22, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants