-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reload when a configmap changes #4586
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4586 +/- ##
=========================================
Coverage ? 58.42%
=========================================
Files ? 88
Lines ? 6708
Branches ? 0
=========================================
Hits ? 3919
Misses ? 2355
Partials ? 434
Continue to review full report at Codecov.
|
/retest |
94e0f3f
to
3d4ed5c
Compare
@aledbf I think e2e test would be straightforward to include in this PR. |
/lgtm since this is blocking another PR, we can add e2e test later |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #4585Special notes for your reviewer: