Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reload when a configmap changes #4586

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 23, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4585

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2019
@codecov-io
Copy link

codecov-io commented Sep 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9b66f2a). Click here to learn what that means.
The diff coverage is 17.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4586   +/-   ##
=========================================
  Coverage          ?   58.42%           
=========================================
  Files             ?       88           
  Lines             ?     6708           
  Branches          ?        0           
=========================================
  Hits              ?     3919           
  Misses            ?     2355           
  Partials          ?      434
Impacted Files Coverage Δ
internal/ingress/annotations/parser/main.go 74.19% <0%> (ø)
internal/ingress/controller/store/store.go 58.64% <21.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b66f2a...3d4ed5c. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2019

/retest

@aledbf aledbf force-pushed the fix-reload branch 4 times, most recently from 94e0f3f to 3d4ed5c Compare September 23, 2019 14:06
@ElvinEfendi
Copy link
Member

@aledbf I think e2e test would be straightforward to include in this PR.

@ElvinEfendi
Copy link
Member

/lgtm

since this is blocking another PR, we can add e2e test later

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2019
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cb2889b into kubernetes:master Sep 24, 2019
@aledbf aledbf deleted the fix-reload branch September 24, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nginx fails to listen to tcp and udp services when no ingress is defined
4 participants